Flow.Launcher.Core/ExternalPlugins/Environments/PythonEnvironment.cs (1)

38-58: Catch folder removal errors and move removal inside the guarded block.

If RemoveFolderIfExists throws (locked files, ACLs), it will escape the try/catch. Move it into the same guarded JTF block so all install steps are handled uniformly and failures are logged once.

-        FilesFolders.RemoveFolderIfExists(InstallPath, (s) => API.ShowMsgBox(s));
-
         // Python 3.11.4 is no longer Windows 7 compatible. If user is on Win 7 and
         // uses Python plugin they need to custom install and use v3.8.9
         JTF.Run(async () =>
         {
             try
             {
+                FilesFolders.RemoveFolderIfExists(InstallPath, (s) => API.ShowMsgBox(s));
                 await DroplexPackage.Drop(App.python_3_11_4_embeddable, InstallPath);
 
                 PluginsSettingsFilePath = ExecutablePath;
             }
             catch (System.Exception e)
             {
-                API.ShowMsgError(API.GetTranslation("failToInstallPythonEnv"));
-                API.LogException(ClassName, "Failed to install Python environment", e);
+                API.ShowMsgError(API.GetTranslation("failToInstallPythonEnv"));
+                API.LogException(ClassName, $"Failed to install Python environment to {InstallPath}", e);
             }
         });

Flow.Launcher/Languages/en.xaml (1)

38-39: Punctuation consistency: end both sentences with a period.

TypeScript string lacks a trailing period while the Python one has it. Align for consistency across resources.

-    <system:String x:Key="failToInstallTypeScriptEnv">Failed to install TypeScript environment. Please try again later</system:String>
+    <system:String x:Key="failToInstallTypeScriptEnv">Failed to install TypeScript environment. Please try again later.</system:String>

Flow.Launcher.Core/ExternalPlugins/Environments/PythonEnvironment.cs (2)

36-37: Avoid creating a new JoinableTaskContext per instance.

Creating a fresh JoinableTaskContext for each environment is unnecessary and may not align with the app’s UI thread. Prefer reusing a shared JTF (e.g., centralized in the base class or app) or at least make this static readonly to reduce overhead.

-        private JoinableTaskFactory JTF { get; } = new JoinableTaskFactory(new JoinableTaskContext());
+        private static readonly JoinableTaskFactory JTF = new JoinableTaskFactory(new JoinableTaskContext());

If feasible, consider exposing a shared JTF from AbstractPluginEnvironment or App to ensure it’s bound to the application’s UI context.

---

42-44: Win7 note: proactively short-circuit with a user-facing hint.

The comment mentions Win7 incompatibility for Python 3.11.4. Consider detecting unsupported OS and skipping install with a clearer message guiding users to manually install a supported version.

I can draft a minimal OS-check guard and a localized message key if you want to include it in this PR.

Flow.Launcher.Core/ExternalPlugins/Environments/TypeScriptV2Environment.cs (3)

23-24: Use Path.Combine for all segments to avoid mixed separators.

Prefer splitting the subpath to avoid embedded backslashes and improve readability/portability.

-        internal override string ExecutablePath => Path.Combine(InstallPath, "node-v16.18.0-win-x64\\node.exe");
+        internal override string ExecutablePath => Path.Combine(InstallPath, "node-v16.18.0-win-x64", "node.exe");

---

33-34: Consider sharing JoinableTaskFactory across environments.

Same as PythonEnvironment: avoid creating a JoinableTaskContext per instance; reuse a shared JTF or make this static readonly.

-        private JoinableTaskFactory JTF { get; } = new JoinableTaskFactory(new JoinableTaskContext());
+        private static readonly JoinableTaskFactory JTF = new JoinableTaskFactory(new JoinableTaskContext());

---

39-52: DRY: factor common installation pattern into a helper.

TypeScriptEnvironment and TypeScriptV2Environment duplicate the same install pattern (remove folder, await Droplex, set settings, handle errors). Consider extracting a protected helper in the base class to reduce duplication and keep behavior consistent.

If you want, I can sketch a protected InstallWithDropAsync helper signature for AbstractPluginEnvironment that both TS environments can call.

Flow.Launcher.Core/ExternalPlugins/Environments/TypeScriptEnvironment.cs (3)

22-24: Prefer Path.Combine with separate segments for clarity.

Avoid embedding backslashes; use Path.Combine for each segment.

-        internal override string ExecutablePath => Path.Combine(InstallPath, "node-v16.18.0-win-x64\\node.exe");
+        internal override string ExecutablePath => Path.Combine(InstallPath, "node-v16.18.0-win-x64", "node.exe");

---

33-34: JoinableTaskFactory instantiation pattern.

As with the other environments, consider a shared/static JTF, or centralize it in AbstractPluginEnvironment/App to align with the app’s UI context and reduce allocations.

-        private JoinableTaskFactory JTF { get; } = new JoinableTaskFactory(new JoinableTaskContext());
+        private static readonly JoinableTaskFactory JTF = new JoinableTaskFactory(new JoinableTaskContext());

---

39-52: Include InstallPath in error log for easier diagnostics.

Adding the target path to the log message speeds up troubleshooting.

-                    API.LogException(ClassName, "Failed to install TypeScript environment", e);
+                    API.LogException(ClassName, $"Failed to install TypeScript environment to {InstallPath}", e);

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

Learnt from: Jack251970
PR: Flow-Launcher/Flow.Launcher#3572
File: Flow.Launcher/App.xaml.cs:214-216
Timestamp: 2025-07-06T12:21:37.947Z
Learning: In Flow Launcher, the UpdatePluginManifestAsync method in PluginsManifest.cs already has comprehensive internal try-catch handling that logs exceptions and returns false on failure rather than throwing, making external try-catch wrappers unnecessary.

Learnt from: Jack251970
PR: Flow-Launcher/Flow.Launcher#3854
File: Flow.Launcher/App.xaml.cs:246-262
Timestamp: 2025-07-21T09:19:49.684Z
Learning: In Flow Launcher's App.xaml.cs, the asynchronous plugin initialization task (containing AbstractPluginEnvironment.PreStartPluginExecutablePathUpdate, PluginManager.LoadPlugins, PluginManager.InitializePluginsAsync, and AutoPluginUpdates) does not require additional try-catch error handling according to maintainer Jack251970, as these operations are designed to handle exceptions internally.